Add MT-Bench and PR-Bench Support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Maredia <[email protected]>
Signed-off-by: Ali Maredia <[email protected]>
Signed-off-by: Ali Maredia <[email protected]>
Signed-off-by: Ali Maredia <[email protected]>
Signed-off-by: Ali Maredia <[email protected]>
danmcp
force-pushed
the
main
branch
23 times, most recently
from
7b11486 to
a9c16f2
Compare
Comment on lines
26
to
28
| with open(fn, "r", encoding="utf-8") as file: | ||
| contents = yaml.safe_load(file) | ||
| return contents.get("seed_examples") |
There was a problem hiding this comment.
Are we checking the YAML/schema validity at all?
Don't think we need for this PR specifically, but @bjhargrave is working on a Dev Doc to get this functionality into the instructlab-schema package: instructlab/dev-docs#101
Closed
danmcp
force-pushed
the
main
branch
13 times, most recently
from
55e6346 to
1594a73
Compare
alimaredia
approved these changes
Jun 25, 2024
| for _ in range(API_MAX_RETRY): | ||
| try: | ||
| messages = conv.to_openai_api_messages() | ||
| if messages[0]["role"] == "system" and messages[1]["role"] == "user": |
There was a problem hiding this comment.
@xukai92 do we need to change this to what's in here? xukai92/FastChat@5d44295. You have an issue for it here: #11
There was a problem hiding this comment.
I went ahead and included. Where are we expecting the env var to be set though?
|
The comments I had in my review are not meant to block the merging of this PR. They are to point out or ask questions about follow up work. |
danmcp
force-pushed
the
main
branch
7 times, most recently
from
d9289cf to
3e21919
Compare
Signed-off-by: Dan McPherson <[email protected]>
JamesKunstle
approved these changes
Jun 25, 2024
nathan-weinberg
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.